Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: xds route not work with regex #2121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bryce-huang
Copy link
Contributor

Issues associated with this PR

#2120

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@doujiang24
Copy link
Member

https://github.com/mosn/mosn/runs/8110553658?check_suite_focus=true#step:4:5608
测试用例失败了,需要处理下的~

@Bryce-huang
Copy link
Contributor Author

https://github.com/mosn/mosn/runs/8110553658?check_suite_focus=true#step:4:5608 测试用例失败了,需要处理下的~

不知道哪里导致的。。。

@taoyuanyuan
Copy link
Contributor

https://github.com/mosn/mosn/runs/8110553658?check_suite_focus=true#step:4:5608 测试用例失败了,需要处理下的~

不知道哪里导致的。。。

--- FAIL: TestUnmarshalResources (0.02s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x22685d0]

goroutine 21 [running]:
testing.tRunner.func1.1(0x24ef240, 0x36a7810)
	/usr/local/go/src/testing/testing.go:999 +0x51b
testing.tRunner.func1(0xc0002b86c0)
	/usr/local/go/src/testing/testing.go:1002 +0x31a
panic(0x24ef240, 0x36a7810)
	/usr/local/go/src/runtime/panic.go:975 +0x41b
mosn.io/mosn/istio/istio1106/xds/conv.convertRouteAction(0xc000193680, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/mosn.io/mosn/istio/istio1106/xds/conv/convert_router.go:226 +0x3e0
mosn.io/mosn/istio/istio1106/xds/conv.convertRoutes(0xc00011f760, 0x1, 0x1, 0x0, 0x0, 0x0)
	/go/src/mosn.io/mosn/istio/istio1106/xds/conv/convert_router.go:85 +0x1c1
mosn.io/mosn/istio/istio1106/xds/conv.ConvertRouterConf(0x0, 0x0, 0xc00012fe00, 0x0, 0x26f1500)
	/go/src/mosn.io/mosn/istio/istio1106/xds/conv/convert_router.go:54 +0x28a
mosn.io/mosn/istio/istio1106/xds/conv.(*filterConverter).convertHTTP(0xc00040ede8, 0xc00009c280, 0x0, 0x2a31d00, 0x0, 

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 60.56% // Head: 60.40% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (5484f26) compared to base (7609947).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   60.56%   60.40%   -0.16%     
==========================================
  Files         422      420       -2     
  Lines       36629    36976     +347     
==========================================
+ Hits        22184    22337     +153     
- Misses      12263    12423     +160     
- Partials     2182     2216      +34     
Impacted Files Coverage Δ
istio/istio1106/xds/conv/convert_router.go 57.83% <40.00%> (-1.02%) ⬇️
pkg/config/v2/server.go 64.70% <0.00%> (-5.51%) ⬇️
...ream/faulttolerance/regulator/default_work_pool.go 88.63% <0.00%> (-4.55%) ⬇️
pkg/stream/http2/var.go 58.69% <0.00%> (-3.81%) ⬇️
pkg/network/listener.go 36.65% <0.00%> (-2.85%) ⬇️
pkg/filter/stream/ipaccess/stream_filter.go 84.37% <0.00%> (-2.73%) ⬇️
pkg/wasm/abi/proxywasm010/factory.go 50.00% <0.00%> (-2.64%) ⬇️
pkg/router/handler.go 57.14% <0.00%> (-2.12%) ⬇️
pkg/router/types.go 48.80% <0.00%> (-1.83%) ⬇️
...kg/upstream/cluster/subset_loadbalancer_builder.go 92.50% <0.00%> (-1.00%) ⬇️
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bryce-huang
Copy link
Contributor Author

already update,pls review

@taoyuanyuan taoyuanyuan requested a review from 3062 December 6, 2022 11:48
@Bryce-huang
Copy link
Contributor Author

done

Copy link
Contributor

@3062 3062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants