-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: xds route not work with regex #2121
base: master
Are you sure you want to change the base?
Conversation
不知道哪里导致的。。。 |
|
Codecov ReportBase: 60.56% // Head: 60.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
- Coverage 60.56% 60.40% -0.16%
==========================================
Files 422 420 -2
Lines 36629 36976 +347
==========================================
+ Hits 22184 22337 +153
- Misses 12263 12423 +160
- Partials 2182 2216 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
already update,pls review |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issues associated with this PR
#2120
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style
Goimports
has runGolint
result