-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature reload cmd #2030
base: master
Are you sure you want to change the base?
Feature reload cmd #2030
Conversation
Codecov ReportBase: 60.56% // Head: 60.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 60.56% 60.52% -0.05%
==========================================
Files 422 422
Lines 36629 36688 +59
==========================================
+ Hits 22184 22205 +21
- Misses 12263 12302 +39
+ Partials 2182 2181 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前的reload是靠向旧进程发送HUP信号触发热升级流程执行reload,但是MOSN是可以通过配置关闭热升级的,有没有测试过这种情况下,reload是什么结果?
补充对应的文档到MOSN官网,需要说明各种细节。 |
1. move changes to istio/main 2. using proc.pid
如果打开热升级执行 reload的话,新进程会向老mosn进程向发热升级信号,老进程会报错 |
好的,等PR合进好,我再提个PR到mosn.io |
这个CI 失败看起来不是我提交的代码影响的。 |
https://github.com/mosn/mosn/runs/8153277565?check_suite_focus=true#step:5:222 |
Issues associated with this PR
支持Mosn reload命令(#1680)
mosn reload
or
mosn reload -c config_path