Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: close the connection when there are no active requests after the connpool has been shutdown. #1967

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

doujiang24
Copy link
Member

we implemented the OnGoAway method and call it in pool shutdown.

we can reuse it for graceful shutdown client connection in #1922

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1967 (7df8b4f) into master (8d97681) will increase coverage by 0.04%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
+ Coverage   61.03%   61.07%   +0.04%     
==========================================
  Files         410      410              
  Lines       35574    35576       +2     
==========================================
+ Hits        21711    21728      +17     
+ Misses      11711    11692      -19     
- Partials     2152     2156       +4     
Impacted Files Coverage Δ
pkg/stream/xprotocol/connpool_multiplex.go 52.70% <30.00%> (-2.02%) ⬇️
...aulttolerance/regulator/invocation_stat_factory.go 85.00% <0.00%> (-15.00%) ⬇️
...ream/faulttolerance/regulator/default_work_pool.go 88.63% <0.00%> (-4.55%) ⬇️
pkg/metrics/shm/zone.go 66.66% <0.00%> (-2.57%) ⬇️
pkg/module/http2/transport.go 78.47% <0.00%> (-0.44%) ⬇️
pkg/module/http2/server.go 81.70% <0.00%> (-0.15%) ⬇️
pkg/stream/xprotocol/conn.go 40.33% <0.00%> (+2.20%) ⬆️
pkg/stream/xprotocol/connpool_pingpong.go 61.90% <0.00%> (+12.16%) ⬆️
pkg/stream/stream.go 46.66% <0.00%> (+13.33%) ⬆️
...ream/faulttolerance/regulator/default_regulator.go 100.00% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d97681...7df8b4f. Read the comment docs.

@taoyuanyuan taoyuanyuan added the WIP Work in progress label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants