New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic version of Sequence
for any number type
#893
base: master
Are you sure you want to change the base?
Conversation
399fbc4
to
f1bf4e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 92.38% 92.39%
=======================================
Files 110 110
Lines 3441 3456 +15
Branches 1020 1022 +2
=======================================
+ Hits 3179 3193 +14
- Misses 200 201 +1
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Approved in principle. Will wait to give final approval. |
@@ -119,7 +119,7 @@ | |||
<NeutralLanguage>en-US</NeutralLanguage> | |||
<VersionPrefix>3.3.2</VersionPrefix> | |||
<Authors>MoreLINQ Developers.</Authors> | |||
<TargetFrameworks>net451;netstandard1.0;netstandard2.0;netstandard2.1;net6.0</TargetFrameworks> | |||
<TargetFrameworks>net451;netstandard1.0;netstandard2.0;netstandard2.1;net6.0;net7.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to include .net7 should be done on a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should wait until v4.0.0, along with .net7 release. Expectation is that v3.4.0 is existing changes plus nullability fixes to include at most .net6 (including conflicting behavior in certain methods). Future improvements should be delayed until after 3.4.0 is released.
This PR adds a generic version of
Sequence
as described in #892.Under .NET 7,
Sequence(int, int, int)
defers toSequence<T>(T, T, T)
and is therefore tested for whenT
isint
.