Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add badges on README.md #813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add badges on README.md #813

wants to merge 2 commits into from

Conversation

leandromoh
Copy link
Collaborator

No description provided.

@leandromoh leandromoh changed the base branch from leandromoh-patch-2 to master March 28, 2021 01:16
@leandromoh leandromoh mentioned this pull request Mar 28, 2021
Closed
@leandromoh leandromoh changed the title use badges as link add badges on reamde Mar 28, 2021
@leandromoh leandromoh changed the title add badges on reamde add badges on README.md Mar 28, 2021
atifaziz
atifaziz reviewed Mar 28, 2021
View reviewed changes
Copy link
Member

@atifaziz atifaziz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but badges are already there on the home page:

image

If you wish to add some of the new ones you're proposing here (like contributors & downloads) then I'd be happy to take a PR against the repo for morelinq.github.io. I don't see much value in adding them to the README.

@viceroypenguin
Copy link
Contributor

I would suggest they be added to readme.md as well. I know many times when I look at projects, I'm browsing on GH, and the readme.md is the first thing I read, and I rarely go to the associated webpage. That's personal experience/opinion though.

@leandromoh
Copy link
Collaborator Author

I would suggest they be added to readme.md as well. I know many times when I look at projects, I'm browsing on GH, and the readme.md is the first thing I read, and I rarely go to the associated webpage.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atifaziz atifaziz atifaziz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leandromoh @viceroypenguin @atifaziz