Add generic version of Sequence for any number type
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atifaziz
force-pushed
the
generic-number-sequence
branch
from
399fbc4
to
f1bf4e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 92.38% 92.39%
=======================================
Files 110 110
Lines 3441 3456 +15
Branches 1020 1022 +2
=======================================
+ Hits 3179 3193 +14
- Misses 200 201 +1
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Approved in principle. Will wait to give final approval. |
| @@ -119,7 +119,7 @@ | |||
| <NeutralLanguage>en-US</NeutralLanguage> | |||
| <VersionPrefix>3.3.2</VersionPrefix> | |||
| <Authors>MoreLINQ Developers.</Authors> | |||
| <TargetFrameworks>net451;netstandard1.0;netstandard2.0;netstandard2.1;net6.0</TargetFrameworks> | |||
| <TargetFrameworks>net451;netstandard1.0;netstandard2.0;netstandard2.1;net6.0;net7.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Update to include .net7 should be done on a separate PR.
There was a problem hiding this comment.
This PR should wait until v4.0.0, along with .net7 release. Expectation is that v3.4.0 is existing changes plus nullability fixes to include at most .net6 (including conflicting behavior in certain methods). Future improvements should be delayed until after 3.4.0 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic version of
Sequenceas described in #892.Under .NET 7,
Sequence(int, int, int)defers toSequence<T>(T, T, T)and is therefore tested for whenTisint.