Add setting for swapping win & alt keys #1078
Open
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briankendall Would it make sense to only present this option on MacOS platforms? |
Hmm, good question. Generally yes, it really only makes sense on the mac. There might be some use for it on other platforms, but if we want to keep the UI cleaner, then it could only be visible on the mac. And others who wish to use it could edit their config files. |
|
I thought of one other reason to keep this setting around for Windows and Linux users: if they're connecting to a macOS host they may want to flip these keys around in that case too. |
mllejezebel
approved these changes
Feb 12, 2024
|
Hi @cgutman, could we merge this into the base branch? |
jordanamr
approved these changes
May 23, 2024
|
this can (and should be) merged, works perfectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #980
Very useful when connecting to a Windows host from a macOS client.