Avoid GeometricMean overflow by using exp and log #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR complicates a formula a bit to avoid overflows. Geometric mean of 100 numbers around 1 billion gets us overflow as multiplying them yields infinity. Numeric roots from that still return infinity. We can take logarithm of all numbers to avoid most prominent overflows that manifest themselves for just few numbers. Add tests: Test with 0 in input failed in previous implementation. Test with more larger values show the overflow issue.
petoju
force-pushed
the
feature/geo-mean-without-overflow
branch
from
fe577d2
to
06458f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complicates a formula a bit to avoid overflows.
Geometric mean of 100 numbers around 1 billion gets us overflow as
multiplying them yields infinity. Numeric roots from that still return
infinity.
We can take logarithm of all numbers to avoid most prominent overflows
that manifest themselves for just few numbers.
Add tests:
Test with 0 in input failed in previous implementation.
Test with more larger values shows the overflow issue.