Added workaround for APE v1 where binary tags are treated as string #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing tags because v1 doesn't use flags.
|
Now all we need is to be able to read and write the tags SPL does to wave files properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications still use APE v1 tags (such as Station Playlist, which is used by a lot of radio stations).
APE v1 does not use flags. Because of this, Taglib treats binary tags which were written by an application that uses APE v1 as strings. Even if it is really binary data.
This change fills both the data and text fields of an APE item.
The "normal flow" reading the text-field, because Type is still set to ItemType.Text.
However if the application knows that the item is really binary, it will be able to read it by setting Type to ItemType.Binary.