Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-5087 Bump MacOS version used for tests #1324

Merged
merged 1 commit into from May 16, 2024

Conversation

sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner May 11, 2024 05:25
@sanych-sun sanych-sun removed the request for review from a team May 11, 2024 05:46
@@ -1867,40 +1873,35 @@ axes:
display_name: "Windows 64-bit"
variables:
OS: "windows-64"
python3_binary: "C:/python/Python38/python.exe"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked our scripts and drivers-evergreen-tools and did not find any usage of the variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you git blame, you'll find my name on the python3_binary lines. I had to add the python3_binary variable to work around python3 detection issues on different variants. Looks like driver-evergreen-tools has fixed the issue and this is no longer required.

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about jq

@@ -1,3 +1,3 @@
#!/usr/bin/env bash
CAKE_VERSION=2.2.0
DOTNET_VERSION=6.0.400
DOTNET_VERSION=8.0.204
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

run_on: ubuntu1804-test
- id: "ubuntu-2004"
display_name: "Ubuntu 20.04"
variables:
OS: "ubuntu-2004"
python3_binary: "/opt/python/3.8/bin/python3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that jq is still available after this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it is. I've include the package_push_myget into the PR patch and it's succeeded.

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1867,40 +1873,35 @@ axes:
display_name: "Windows 64-bit"
variables:
OS: "windows-64"
python3_binary: "C:/python/Python38/python.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you git blame, you'll find my name on the python3_binary lines. I had to add the python3_binary variable to work around python3 detection issues on different variants. Looks like driver-evergreen-tools has fixed the issue and this is no longer required.

@sanych-sun sanych-sun merged commit 4672e59 into mongodb:master May 16, 2024
82 of 94 checks passed
@sanych-sun sanych-sun deleted the csharp5087 branch May 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants