Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSHARP-5071: Support string concatenation of mixed types. #1317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CSHARP-5071: Support string concatenation of mixed types. #1317

wants to merge 2 commits into from

Conversation

rstam
Copy link
Contributor

@rstam rstam commented May 3, 2024

No description provided.

@rstam rstam requested a review from a team as a code owner May 3, 2024 20:23
@rstam
Copy link
Contributor Author

rstam commented May 3, 2024

Added tests for all combinations of string concatenation using + or string.Concat and implemented any missing support.

damieng
damieng requested changes May 8, 2024
View reviewed changes
Copy link
Member

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to address those test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rstam @damieng