PHPORM-127 Fix priority of embeds vs attributes #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
embeds-priority
branch
2 times, most recently
from
da4339c
to
81a0fc6
Compare
GromNaN
commented
Aug 30, 2023
| // First, we'll need to determine the foreign key and "other key" for the | ||
| // relationship. Once we have determined the keys we'll make the query | ||
| // instances as well as the relationship instances we need for this. | ||
| $foreignKey = $foreignKey ?: $this->getForeignKey().'s'; | ||
|
|
||
| $instance = new $related; | ||
|
|
||
| if ($otherKey === $relation) { | ||
| throw new \LogicException(sprintf('In %s::%s(), the key cannot be identical to the relation name "%s". The default key is "%s".', static::class, $relation, $relation, $instance->getForeignKey().'s')); |
There was a problem hiding this comment.
The solution was so easy, just don't name the foreign key the same as the relation; that is the default behavior if you don't pass any foreign keys to $this->belongsToMany(related , /* Don't pass anything else */) , and that is also the documented way to do it.
I propose to throw an exception in this case to avoid any error.
GromNaN
commented
Aug 30, 2023
tests/Models/User.php
Outdated
|
|
||
| public function otherGroups() | ||
| { | ||
| return $this->belongsToMany(Group::class, 'groups', 'users', 'otherGroups', '_id', '_id', 'groups'); |
There was a problem hiding this comment.
I'm going to add a test for the exception.
GromNaN
force-pushed
the
embeds-priority
branch
from
171d8c2
to
68afe15
Compare
GromNaN
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2577 (continuing)
Fix PHPORM-127
Moving the code from the
Modelclass to theEmbedsRelationstrait.