Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Express.js to v5 #921

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: update Express.js to v5 #921

wants to merge 1 commit into from

Conversation

rtritto
Copy link
Member

@rtritto rtritto commented Sep 1, 2022 •
edited by dozoisch

This change is Reviewable

Migrate to v5

@rtritto
Copy link
Member Author

rtritto commented Sep 9, 2022

Correctly rebased with master.
FYI @shakaran

@shakaran
Copy link
Collaborator

shakaran commented Sep 9, 2022

Correctly rebased with master. FYI @shakaran

it seems that still fail for the pipelines

@rtritto
Copy link
Member Author

rtritto commented Sep 9, 2022 •
edited

Correctly rebased with master. FYI @shakaran

it seems that still fail for the pipelines

I know, that fix works only with express v5.
My base idea is to wait a stable/rc express v5 to update the dependency. By this way, we should have less conflicts with rebases/synch.

@rtritto rtritto added the dependencies Pull requests that update a dependency file label Sep 12, 2022
@rtritto rtritto removed the feature label Sep 20, 2022
@rtritto rtritto added this to the Future - Backlog milestone Dec 23, 2022
@rtritto rtritto changed the title Update Express.js to v5 chore: update Express.js to v5 Feb 20, 2023
@rtritto rtritto removed the deprecate label Oct 21, 2023
@shakaran
Copy link
Collaborator

shakaran commented Dec 7, 2023

@rtritto this need rebase or update maybe

@shakaran
Copy link
Collaborator

@rtritto any update with this?

@rtritto
Copy link
Member Author

rtritto commented Feb 20, 2024

v5 isn't updated with v4. Before merge, I would wait for the v5 to become stable.
express seems not mantained so we should consider to migrate to fastify. I did this branch https://github.com/mongo-express/mongo-express/tree/fastify-migration as draft.

@shakaran
Copy link
Collaborator

v5 isn't updated with v4. Before merge, I would wait for the v5 to become stable. express seems not mantained so we should consider to migrate to fastify. I did this branch https://github.com/mongo-express/mongo-express/tree/fastify-migration as draft.

In that versión, I see that we lost the support for swigEngine, could you add it too and make a PR rebased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file draft upgrade
Projects
None yet
Milestone
Future - Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtritto @shakaran