Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor bug local assets path when loading mongo-express as middleware #1534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix minor bug local assets path when loading mongo-express as middleware #1534

wants to merge 1 commit into from

Conversation

royalgarter
Copy link

@royalgarter royalgarter commented May 6, 2024 •
edited by dozoisch

This change is Reviewable

  • Add support for apply local assets path from config

Fix minor bug local assets path when loading mongo-express as middleware
16534fb 
- Add support for apply local assets path from config
@rtritto
Copy link
Member

rtritto commented May 6, 2024

Should we handle the asset path as environment variable instead of use config.locals.assets?

@royalgarter
Copy link
Author

Should we handle the asset path as environment variable instead of use config.locals.assets?

Yes, i think we can support both ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royalgarter @rtritto