Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more ssl connection options #1142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mhf-ir
Copy link

@mhf-ir mhf-ir commented Feb 22, 2023

This change is Reviewable


Fix #1141
Close #574

@rtritto
Copy link
Member

rtritto commented Feb 23, 2023

Related #574

@mhf-ir
Copy link
Author

mhf-ir commented Feb 23, 2023

any idea how to solve this essential problem, how to connect to mongo via self sing and client cert ? #574 belongs to 2020

@rtritto
Copy link
Member

rtritto commented Feb 23, 2023

This replaces #574 and should close it.

Should we use getFile?
Example:

sslCA:: getFile(process.env.ME_CONFIG_MONGODB_CA_FILE)

@mhf-ir
Copy link
Author

mhf-ir commented Feb 24, 2023

on latest MongoDB driver it's not file content, it's path of pem file. no need to read as Blob/String. just path of file.

also all ssl* prefix also renamed to tls

@rtritto
Copy link
Member

rtritto commented Jul 30, 2023

mongodb was updated to v5.
In v6, as @mhf-ir said, there are some changes (ssl* options are renamed to tls*): Changes mongodb v6.
In this PR or in a new/separated PR, we should rename ssl options to tls (#1203).

FYI @shakaran @BlackthornYugen @dugrema

@rtritto rtritto mentioned this pull request Aug 31, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl client options for full tls communication support client cert
2 participants