WOMBAT BGC updates #368
Merged
WOMBAT BGC updates #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this commit should serve as an example for adding a variable to the coupler. - in addition to the source code, the new field needs to be added to: - namcouple - ice/input_ice.nml - ocean/input.nml in the config directory.
…ation. compilation successful on my directory.
…not used. with this commit, no need to make unnecessary input files for higher resolutions.
…ing climatology for gas flux calculation. compilation ok but execution bad.
-add MLD-integrated diagnostic following light_limit.
… produce the same output (more or less) but the removed method produces errorneous grid lines.
…r flux calcualtion for now).
…ce-to-ocean bgc flux is added to the ocean bgc tendency when computing virtual flux.
Merged
|
Hi @russfiedler would you have the time to look over this PR please? I think we've resolved all the issues now... at least I hope so, as we are using this for IAF cycle 4! |
|
Would anyone object if I merge these BGC updates? f51926f is being used in a production run https://github.com/COSIMA/01deg_jra55_iaf/tree/01deg_jra55v140_iaf_cycle4 and seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOMBAT BGC enhancements and bug fixes, as used in 01deg_jra55v140_iaf_cycle4 and the master+bgc branches of the standard ACCESS-OM2 configurations.
fediagnostics Incorrect units for iron diagnostics in WOMBAT #367This PR supersedes #356