feat: load table linkfile #123
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
========================================
- Coverage 85.2% 85.2% -0.1%
========================================
Files 9 9
Lines 502 522 +20
========================================
+ Hits 428 445 +17
- Misses 74 77 +3 ☔ View full report in Codecov by Sentry. |
R/table.R
Outdated
| #' Helper function to get the contents of a linkfile | ||
| #' | ||
| #' @param project projectname where the linkfile is stored | ||
| #' @param objectname folder/name of linkfile |
There was a problem hiding this comment.
This should be object_name and not object_name
| @@ -132,7 +132,17 @@ armadillo.copy_table <- # nolint | |||
| #' | |||
| #' @export | |||
| armadillo.load_table <- function(project, folder, name) { # nolint | |||
There was a problem hiding this comment.
I've tested this and it works. However it's not very generic - e.g. if we want to expand this to loading other types of object. I'm happy to approve for now, but maybe next time we want to extend this to other object types we should think about refactoring so we can more easily add support for other types?
There was a problem hiding this comment.
That's valid. We do however really have to think about how to make it more generic. Possibly pass a loadfunction to it then, don't know. Maybe we can create a story for it? I think for now this is good enough, but I do agree that it's a bit limited.
|
Closes issue #111 |
No description provided.