Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to inherit from UIControl #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kmcelyea
Copy link

This allows the developer to add targets and selectors to the view which means you can use a customview right and left nav with this class.

I have tested this change on my local project

Here is what it allows me to create

STIconView *logout = [factory iconViewForIconNamed:@"logout" withSide:32.0f];
[logout addTarget:self action:@selector(logout:) forControlEvents:UIControlEventTouchUpInside];
UIBarButtonItem * rightBarButtonItem = [[UIBarButtonItem alloc]initWithCustomView:logout];

self.navigationItem.rightBarButtonItem = rightBarButtonItem;

A custom view bar button item doesn't come with a target or selector. The view being passed to it is supposed to handle the target and selector.

This allows the developer to add targets and selectors to the view which means you can use a customview right and left nav with this class.
@mokagio
Copy link
Owner

mokagio commented Sep 15, 2014

Hello there! Thanks for the PR 🍻

I'm a bit busy atm, but I'll look at it as soon as I can!

@Kmcelyea
Copy link
Author

Not a problem just wanted to share this with you and see what you thought about adding it to the build.

@mokagio
Copy link
Owner

mokagio commented Feb 18, 2015

Hey @Kmcelyea I haven't forgotten about this PR! I've just been quite busy with other projects. I'll get onto it sooner or later. Thanks again for your help and patience 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants