Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions to stash regardless of format #2065

Merged
merged 1 commit into from May 8, 2023

Conversation

rawleyfowler
Copy link
Contributor

@rawleyfowler rawleyfowler commented May 5, 2023

Summary

Make it easier to use exceptions, when exception format is not HTML

Motivation

It doesn't make sense for exceptions to be stored in the stash only if the format is HTML, instead it makes more sense, and is more consistent to store them in the stash for all formats

References

fixes #2048

I annihilated my branch on the other PR like a goof #2061 and github auto closed the PR because of it.

@kraih kraih requested review from a team, kraih, jhthorsen and christopherraa May 5, 2023 15:36
marcusramberg
marcusramberg previously approved these changes May 5, 2023
Copy link
Member

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm :)

@rawleyfowler
Copy link
Contributor Author

@marcusramberg Had to make a change $e->inspect could break

@marcusramberg
Copy link
Member

@marcusramberg Had to make a change $e->inspect could break

Its failing test now?

@rawleyfowler
Copy link
Contributor Author

rawleyfowler commented May 5, 2023

@marcusramberg The tests pass, there is a bug with github workflow where it can't find the module if you look at the logs. Not sure.

t/mojolicious/exception_lite_app.t ......... ok

Can't locate Test2/V0.pm in @INC (@INC contains: /__w/mojo/mojo/lib /usr/local/lib/perl5/site_perl/5.16.3/x86_64-linux /usr/local/lib/perl5/site_perl/5.16.3 /usr/local/lib/perl5/5.16.3/x86_64-linux /usr/local/lib/perl5/5.16.3 .) at /usr/local/lib/perl5/site_perl/5.16.3/x86_64-linux/Test/Future/AsyncAwait/Awaitable.pm line 11.

@rawleyfowler
Copy link
Contributor Author

@kraih Is this failing test my doing or is the @INC broken?

jhthorsen
jhthorsen previously approved these changes May 7, 2023
@mergify mergify bot dismissed jhthorsen’s stale review May 8, 2023 13:46

Pull request has been modified.

@rawleyfowler rawleyfowler force-pushed the stash-exceptions branch 2 times, most recently from d1871b4 to c8f5869 Compare May 8, 2023 14:27
Copy link
Member

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot merged commit 20b20d6 into mojolicious:main May 8, 2023
10 checks passed
@rawleyfowler rawleyfowler deleted the stash-exceptions branch May 11, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions are not available in the after_dispatch hook when exception_format is set to json
3 participants