Convert t/mojo/reactor_ev.t to use subtests #1970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash commits. |
misch2
force-pushed
the
michals/convert-tests-to-use-subtests-reactor-ev
branch
from
fc2f924
to
e67753f
Compare
|
Commits squashed |
jhthorsen
reviewed
Aug 16, 2022
jhthorsen
reviewed
Aug 18, 2022
|
I also think you might want to squash the commits and write a more descriptive commit message. |
misch2
force-pushed
the
michals/convert-tests-to-use-subtests-reactor-ev
branch
from
6060e16
to
5a8c74d
Compare
|
Commits squashed. |
kraih
reviewed
Aug 18, 2022
jhthorsen
reviewed
Aug 20, 2022
misch2
force-pushed
the
michals/convert-tests-to-use-subtests-reactor-ev
branch
from
dc9e7e4
to
ed0a5e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests in
t/mojo/reactor_ev.tconverted to use subtests.Motivation
Help convert remaining subtests.
References
#1520