Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert t/mojolicious/layouted_lite_app.t to use subtests #1682

Conversation

markogrady1
Copy link
Contributor

Summary

convert t/mojolicious/layouted_lite_app.t to use subtests

Motivation

want to contribute to the subtest conversion

References

discussion: #1520

jhthorsen
jhthorsen previously approved these changes Jan 31, 2021
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shadowcat-mst
shadowcat-mst previously approved these changes Feb 2, 2021
Copy link
Contributor

@shadowcat-mst shadowcat-mst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2021

This pull request is now in conflicts. Could you fix it @markogrady1? 🙏

@markogrady1 markogrady1 force-pushed the convert-layouted_lite_app-to-use-subtests branch from e9fa86a to 940a1dd Compare February 13, 2021 10:24
@markogrady1 markogrady1 force-pushed the convert-layouted_lite_app-to-use-subtests branch from 940a1dd to d4224dc Compare February 13, 2021 10:29
@mergify mergify bot merged commit 66f8968 into mojolicious:master Feb 16, 2021
@markogrady1 markogrady1 deleted the convert-layouted_lite_app-to-use-subtests branch February 17, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants