Convert cleanly proxy.t and websocket_proxy.t to use subtests #1520 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spazm
changed the title
spazm
force-pushed
the
fix/1520-5-tests-hypnotoad-to-user_agent_unix
branch
from
a129c50
to
29db4d5
Compare
kraih
reviewed
Nov 1, 2020
| is $tx->res->body, 'Hello Hypnotoad!', 'right content'; | ||
| }; | ||
|
|
||
| my $shared_tx; |
kraih
reviewed
Nov 1, 2020
| @@ -20,110 +20,125 @@ use Mojo::UserAgent; | |||
| use Mojo::Util qw(url_escape); | |||
| use Mojolicious::Lite; | |||
|
|
|||
| # Silence | |||
| app->log->level('fatal'); | |||
| subtest "Silence" => sub { | |||
kraih
reviewed
Nov 1, 2020
|
|
||
| my $test = $dir->child('test.sock'); | ||
| my $encoded = url_escape "$test"; | ||
| my $daemon; |
kraih
requested changes
Nov 1, 2020
|
This pull request is now in conflicts. Could you fix it @spazm? 🙏 |
|
I'm sorry, but i've decided to close these PRs, because they contain too many converted tests at once. And we don't have the review capacity to re-review the whole thing after every scoping issue fix. |
spazm
changed the title
|
Rebased away the tests that did not convert cleanly. The PR is updated with 3 files that require only minimal non-whitespace changes. Hopefully this will be less of a review burden. I apologize for the state of this PR last night, I had no idea you'd come read it so quickly! (which is awesome!) |
spazm
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert two tests to use subtests.
proxy.t: single commented section converted cleanly to subtest. requiring no additional changes.websocket_proxy.t: converted cleanly from comment blocks into subtests.$kept_alive,$resultand$uaneeded declaration and/or initialization in the subtests.Motivation
requested in #1520
References
Issue #1520