Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket Lite app test uses subtests #1587

Merged
merged 1 commit into from Oct 27, 2020
Merged

Websocket Lite app test uses subtests #1587

merged 1 commit into from Oct 27, 2020

Conversation

rabbiveesh
Copy link
Contributor

Summary

Switching test suite to using subtests

Motivation

As discussed in issue #1520

@kraih kraih requested a review from a team October 26, 2020 12:35
marcusramberg
marcusramberg approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mergify mergify bot merged commit 02cf72a into mojolicious:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusramberg marcusramberg marcusramberg approved these changes

@jberger jberger jberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rabbiveesh @marcusramberg @jberger