Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert path.t to subtests #1582

Merged
merged 1 commit into from Oct 28, 2020
Merged

Convert path.t to subtests #1582

merged 1 commit into from Oct 28, 2020

Conversation

kiwiroy
Copy link
Contributor

@kiwiroy kiwiroy commented Oct 26, 2020

Summary

Tests for Mojo::Path in t/mojo/path.t converted to use subtests.

Motivation

Continue ongoing effort.

References

#1520

@kraih kraih requested a review from a team October 26, 2020 12:21
jhthorsen
jhthorsen approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find anything wrong here 👍

@mergify mergify bot merged commit f09eb83 into mojolicious:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhthorsen jhthorsen jhthorsen approved these changes

@jberger jberger jberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiwiroy @jhthorsen @jberger