Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert t/mojo/reactor_detect.t to use subtests #1572

Merged
merged 1 commit into from Oct 11, 2020
Merged

Convert t/mojo/reactor_detect.t to use subtests #1572

merged 1 commit into from Oct 11, 2020

Conversation

dz-at-tc
Copy link
Contributor

Summary

Convert t/mojo/reactor_detect.t to use subtests.

Motivation

One more file converted.

References

Issue #1520

@kraih kraih requested review from Grinnz and a team and removed request for Grinnz October 11, 2020 00:27
jhthorsen
jhthorsen approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mergify mergify bot merged commit 39989a0 into mojolicious:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

@jhthorsen jhthorsen jhthorsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dz-at-tc @kraih @jhthorsen