Convert t/mojo/json_pointer.t to use subtests #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I was not 100% sure how you wanted to handle the various "get" subtests that share the $pointer variable across subtests. At least for now I left the sharing in place and created nested subtests (though I'm certainly not in love with the name "[shared pointer]"... patches welcome!). Actually, as I write this it finally dawned on me that all I really had to do was factor out the variable, not add a nested subtest... Mea culpa, I will fix that now and re-push shortly... |
dz-at-tc
force-pushed
the
add_subtests_to_json_pointer_t
branch
from
0b07619
to
9328299
Compare
kraih
reviewed
Oct 10, 2020
dz-at-tc
force-pushed
the
add_subtests_to_json_pointer_t
branch
from
9328299
to
a53f467
Compare
kraih
reviewed
Oct 11, 2020
dz-at-tc
force-pushed
the
add_subtests_to_json_pointer_t
branch
from
a53f467
to
92cda9f
Compare
kraih
approved these changes
Oct 11, 2020
jhthorsen
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert t/mojo/json_pointer.t to use subtests.
Motivation
One more file converted.
References
Issue #1520