Convert ioloop.t to subtests #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Sep 17, 2020
kiwiroy
force-pushed
the
ioloop-subtests
branch
from
7200235
to
d940e29
Compare
jhthorsen
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Using https://github.com/mojolicious/mojo/pull/1566/files?w=1 I think it looks good
kraih
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests for
Mojo::IOLoopint/mojo/ioloop.tconverted to subtests.Motivation
On going effort.
References
#1520