Convert t/mojo/daemon.t to use subtests #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshisugimo
force-pushed
the
use-subtest
branch
2 times, most recently
from
d20aa2f
to
56a93d9
Compare
kraih
reviewed
Aug 28, 2020
t/mojo/daemon.t
Outdated
| }; | ||
|
|
||
| subtest 'Timeouts' => sub { | ||
| { |
There was a problem hiding this comment.
It was unnecessary.
kraih
reviewed
Aug 28, 2020
t/mojo/daemon.t
Outdated
| is_deeply(Mojo::Server::Daemon->new->listen, ['http://*:80', 'https://*:443'], 'right value'); | ||
| } | ||
| my $ua = Mojo::UserAgent->new; | ||
| my $tx = $ua->get('/'); |
There was a problem hiding this comment.
I don't think this line belongs here.
kraih
reviewed
Aug 28, 2020
t/mojo/daemon.t
Outdated
| }; | ||
|
|
||
| subtest 'Request limit' => sub { | ||
| $daemon = Mojo::Server::Daemon->new(app => $app, listen => ['http://127.0.0.1'], silent => 1)->start; |
There was a problem hiding this comment.
$daemon is not in the right scope.
kraih
reviewed
Aug 28, 2020
t/mojo/daemon.t
Outdated
| like $@, qr/IO::Socket::SSL/, 'right error'; | ||
| }; | ||
|
|
||
| subtest 'bstract methods' => sub { |
|
56a93d9...0c444f9 |
|
Squash your commits. |
toshisugimo
force-pushed
the
use-subtest
branch
from
0c444f9
to
46f5147
Compare
|
Squashed |
christopherraa
approved these changes
Sep 4, 2020
|
You missed these issues. 34d86b6...46b8784 |
|
Oops. Thank you for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
t/mojo/daemon.tto use subtestsMotivation
References
#1520