Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement asyncio receivers #134

Draft
wants to merge 4 commits into
base: 🐟
Choose a base branch
from
Draft

Implement asyncio receivers #134

wants to merge 4 commits into from

Conversation

moggers87
Copy link
Owner

@moggers87 moggers87 commented Jan 3, 2020

Initial support for asyncio based receivers (using aiosmtpd)

@moggers87 moggers87 force-pushed the 59-aiosmptd branch 3 times, most recently from bb006af to 36bdb1c Compare January 7, 2020 02:45
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.58%.
The diff coverage is 93.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   94.23%   94.81%   +0.58%     
==========================================
  Files          15       15              
  Lines        1508     1561      +53     
  Branches      226      230       +4     
==========================================
+ Hits         1421     1480      +59     
+ Misses         62       54       -8     
- Partials       25       27       +2     
Impacted Files Coverage Δ
salmon/server.py 95.87% <93.75%> (+5.01%) ⬆️
salmon/utils.py 88.31% <100.00%> (ø)
salmon/encoding.py 94.28% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be343bd...05ded07. Read the comment docs.

@moggers87 moggers87 force-pushed the 59-aiosmptd branch 5 times, most recently from c455f82 to 851c5d6 Compare January 8, 2020 17:21
@moggers87 moggers87 force-pushed the 59-aiosmptd branch 7 times, most recently from b43ae9c to 69203d5 Compare July 5, 2020 05:13
@moggers87 moggers87 marked this pull request as ready for review July 5, 2020 05:44
Also remove PyPy as I don't think a newer version is available on Travis
that isn't also really really slow.
@moggers87 moggers87 force-pushed the 59-aiosmptd branch 2 times, most recently from cc98d19 to 480cbe8 Compare July 12, 2020 09:31
@moggers87 moggers87 force-pushed the 59-aiosmptd branch 2 times, most recently from bde9d85 to 466e91c Compare July 14, 2020 15:58
@moggers87 moggers87 force-pushed the 59-aiosmptd branch 3 times, most recently from 929bbff to 813b00f Compare July 29, 2020 19:48
@moggers87
Copy link
Owner Author

There's quite a bit that needs doing here but I get the feeling that upstream is a bit dead right now. Might put some time into reviving it if I can but until that this PR is stalled.

@moggers87 moggers87 marked this pull request as draft October 10, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Salmon from smtpd to aiosmtpd
1 participant