[driver] DW3110 UWB radio #1124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elias H. <46895028+kingelilol@users.noreply.github.com>
Co-authored-by: Elias H. <46895028+kingelilol@users.noreply.github.com>
rleh
commented
Apr 2, 2024
|
|
||
| modm::ResumableResult<bool> | ||
| receive(void); | ||
| uint8_t receive_rx_data[20]; |
There was a problem hiding this comment.
Why not std::array? (And in a lot of other places too)
Comment on lines
+75
to
+79
| template<modm::Dw3110Register::SpiMode mode> | ||
| modm::ResumableResult<void> | ||
| send(uint16_t address, std::span<uint8_t> data); | ||
| uint16_t send_tx_header = 0; | ||
| uint32_t send_size = 0; |
There was a problem hiding this comment.
Suggested change
| template<modm::Dw3110Register::SpiMode mode> | |
| modm::ResumableResult<void> | |
| send(uint16_t address, std::span<uint8_t> data); | |
| uint16_t send_tx_header = 0; | |
| uint32_t send_size = 0; | |
| template<modm::Dw3110Register::SpiMode mode> | |
| modm::ResumableResult<void> | |
| send(uint16_t address, std::span<uint8_t> data); | |
| uint16_t send_tx_header = 0; | |
| uint32_t send_size = 0; |
Comment on lines
+61
to
+62
| uint8_t ping_result_data[4]; | ||
| std::span<uint8_t> ping_result{ping_result_data}; |
There was a problem hiding this comment.
Why a C array and std::span?
I think you want to use std::array...
Comment on lines
+31
to
+39
| template<typename SpiMaster, typename Cs, uint32_t buffer_size> | ||
| modm::ResumableResult<bool> | ||
| modm::Dw3110Phy<SpiMaster, Cs, buffer_size>::ping() | ||
| { | ||
| RF_BEGIN(); | ||
| RF_CALL_BLOCKING(send<modm::Dw3110Register::SpiMode::FULL_READ>( | ||
| modm::Dw3110Register::DwRegister::DEV_ID, ping_result)); | ||
| RF_END_RETURN((*((uint32_t *)ping_result.data()) & ~(0b1111)) == 0xDECA0300); | ||
| } |
There was a problem hiding this comment.
Suggested change
| template<typename SpiMaster, typename Cs, uint32_t buffer_size> | |
| modm::ResumableResult<bool> | |
| modm::Dw3110Phy<SpiMaster, Cs, buffer_size>::ping() | |
| { | |
| RF_BEGIN(); | |
| RF_CALL_BLOCKING(send<modm::Dw3110Register::SpiMode::FULL_READ>( | |
| modm::Dw3110Register::DwRegister::DEV_ID, ping_result)); | |
| RF_END_RETURN((*((uint32_t *)ping_result.data()) & ~(0b1111)) == 0xDECA0300); | |
| } | |
| // private in class: `uint32_t tmp_u32;` | |
| template<typename SpiMaster, typename Cs, uint32_t buffer_size> | |
| modm::ResumableResult<bool> | |
| modm::Dw3110Phy<SpiMaster, Cs, buffer_size>::ping() | |
| { | |
| RF_BEGIN(); | |
| RF_CALL(send<modm::Dw3110Register::SpiMode::FULL_READ>(modm::Dw3110Register::DwRegister::DEV_ID, tmp_u32)); | |
| tmp_u32 =& ~0b1111; | |
| RF_RETURN(tmp_u32 == 0xDECA0300); | |
| RF_END(); | |
| } |
Comment on lines
+46
to
+47
| RF_BEGIN(); | ||
| RF_END_RETURN_CALL(send<mode>(address, std::span<uint8_t>())); |
There was a problem hiding this comment.
This can be abbreviated:
Suggested change
| RF_BEGIN(); | |
| RF_END_RETURN_CALL(send<mode>(address, std::span<uint8_t>())); | |
| return send<mode>(address, std::span<uint8_t>()); |
(But I don't understand what the inplace created std::span is meant to do.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for other DW3xxx chips