Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#222 Use ZipFile API to set timestamps #230

Merged
merged 1 commit into from Feb 11, 2024

Conversation

aalmiray
Copy link
Contributor

@aalmiray aalmiray commented Feb 8, 2024

Fixes #222

@aalmiray
Copy link
Contributor Author

aalmiray commented Feb 8, 2024

@hboutemy, @ppkarwasz Here's the first attempt. All tests are green.

Copy link

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except some small remarks.

Copy link

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalmiray aalmiray merged commit 5d63f7b into moditect:main Feb 11, 2024
1 check passed
@aalmiray aalmiray deleted the gh222/reproducible-timestamp branch February 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated JAR file depends on default time zone
2 participants