Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding include-locales flag #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denismakogon
Copy link

Closes #127

@aalmiray
Copy link
Contributor

I think it would also be a good idea if a generic list of args were to be specified as inputs, that way we won't have to release a new version of the plugin when new arguments are added to jlink.

cc :@gunnarmorling

@denismakogon
Copy link
Author

@aalmiray but how many args are there? There are only a few of them which means it's better to give per-arg change that makes every one of them much easier to validate.

@aalmiray
Copy link
Contributor

That is the thing, its a generic way to pass arbitrary args to jlink. It’s the developer’s responsibility to set these args with the correct format and settings, no validation will be performed.

Validation may only be performed with explicit args. Now, if you run jlink —help you see a handful of arguments that could be explicitly mapped to plugin args. The one you are requesting belongs to a jlink plugin. The question is, is this plugin always active?

What happens if someone requests a plugin arg and said plugin is not active by default? Or are all plugins always active?

@denismakogon
Copy link
Author

@aalmiray okay, fair enough. I can update this PR just to introduce an all-purpose generic-style plugin argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --include-locales option
2 participants