New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible build #189
Reproducible build #189
Conversation
Supersedes #177 |
@aalmiray any blocker before merging and releasing? |
@hboutemy waiting for a review from @gunnarmorling as the changes posted are more extensive that I thought |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question inline, but it's not a blocker. Feel free to merge one way or the other. Thanks!
description = "Path to the module-info.java descriptor", | ||
converter = PathConverter.class | ||
) | ||
@Parameter(names = "--module-info", required = true, description = "Path to the module-info.java descriptor", converter = PathConverter.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually more readable? Not that I'm interested in having a formatting style discussion, but could we configure it so it doesn't join wrapped lines? At least there's such an option in the Eclipse formatter. If it's not doable here for some reason, let's go with the proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the formatting configuration from the moditect-org-parent project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, can we then perhaps add the "don't join wrapped lines" config there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell it's already there
<setting id="org.eclipse.jdt.core.formatter.join_wrapped_lines" value="false"/>
@aalmiray time for merge and release? |
FYI: i just checked RB for this release and all went well!!! the plugin itself is reproducible |
Updates parent pom to make build reproducible.
As a side effect the code-formatter was also updated hence why so many source files have also been updated.