Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AddModuleInfoMojo.jvmVersion non-readonly #188

Merged
merged 1 commit into from Mar 23, 2023
Merged

Make AddModuleInfoMojo.jvmVersion non-readonly #188

merged 1 commit into from Mar 23, 2023

Conversation

Marcono1234
Copy link
Contributor

Fixes #75 (see last comment there)

In the pull request which initially added this parameter (#54) it was not mentioned why the parameter has readonly = true, so I assume it was a copy and paste error.

@gunnarmorling gunnarmorling merged commit 8a29a60 into moditect:main Mar 23, 2023
1 check passed
@gunnarmorling
Copy link
Member

Good catch, thx!

@Marcono1234 Marcono1234 deleted the patch-1 branch March 23, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jvmVersion is readonly
2 participants