Fixed problem with duplicate modules while generating module-info (#113) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalmiray
reviewed
Mar 1, 2023
| StringBuilder modules = new StringBuilder(); | ||
| StringBuilder modulePath = new StringBuilder(); | ||
| boolean isFirst = true; | ||
| List<String> modules = new ArrayList<>(); |
There was a problem hiding this comment.
Better use a Set instead of List.
There was a problem hiding this comment.
A Set might reorder the modules and introduce a new undefined order. I would rather not risk this with my limited knowledge of this project.
If you don't agree and/or have more insights, please feel free to improve it further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #113.