Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing CDI SE Example #237

Open
antoinesd opened this issue Mar 13, 2024 · 2 comments
Open

Contributing CDI SE Example #237

antoinesd opened this issue Mar 13, 2024 · 2 comments

Comments

@antoinesd
Copy link
Contributor

Hi All

I have a functioning simple example of CDI 4.0 SE application running with moditect. The final image which includes Weld, various Jakarta EE API, JBoss-logging and other dependencies weight around 61 MB (with zip-9 compression).
example is here
I'd be more than happy to contribute it to the project. If the team is ok with that, how to proceed ?

@gunnarmorling
Copy link
Member

Hey @antoinesd, long time, no see! Sure, more examples will be definitely welcomed. In particular since the existing ones are really outdated, the dependency versions haven't been updated in a long time. So a 2024 example would be great to have.

In regards to next steps, perhaps you could provide a draft PR which shows the overall direction so we can discuss that one? // CC @aalmiray

@antoinesd
Copy link
Contributor Author

Hello @gunnarmorling nice to have time to contribute to your work again. My PR is posted and I made a smaller one to fix #206 @aalmiray is already reviewing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants