disable LRUCache "allCaches" feature by default #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's totally unexpected hidden feature which causes memory leaks. I belive most users don't even know about existense of such a feature. And I don't see any usages of this feature in Mockserver own code as well.
|
^^^ ping @eric6iese @jamesdbloom |
1 similar comment
|
^^^ ping @eric6iese @jamesdbloom |
|
Is anybody alive here? @jamesdbloom @eric6iese @KerchumA222 @jsoref |
|
I'm not an member of this organization |
|
@asolntsev Hi Andrei, I would appreciate the change, as I don't get why this feature exists at all (I haven't investitaged further than the threading-problem), but I am not a maintainer of this project. I just submitted the fix for the synchronisation issue. |
|
Egh... Who is the maintainer then?.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eric6iese @jamesdbloom
it's totally unexpected hidden feature which causes memory leaks.
I believe most users don't even know about existence of such a feature. And I don't see any usages of this feature in MockServer own code as well.
P.S.
allCacheswas improved in https://github.com/mock-server/mockserver/pull/1648/files, but I suggest to improve it even more. :)