Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delay parallel pool termination to prevent false negatives #4959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: delay parallel pool termination to prevent false negatives #4959

wants to merge 1 commit into from

Commits on Jan 13, 2023

  1. Delay parallel pool termination until finally block 

    I found that moving `await pool.terminate()` into the finally block here could prevent some false negatives, where tests could fail but node would mysteriously exit 0 anyway.
    @echuber2
    echuber2 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    08245b5 View commit details
    Browse the repository at this point in the history