Handled exception of--file option with non-existed file(#4047)
#4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Function `handleRequires` is used both when commanded using --require and --file.
|
ref: #4047 |
outsideris
added
type: bug
…`--file` - rollback annotation of Function `handleRequires`
craigtaub
reviewed
Nov 23, 2019
| exports.handleFiles = (files = []) => { | ||
| files.forEach(file => { | ||
| if (!fs.existsSync(file, {cwd})) { | ||
| throw Error(`Cannot find module '${file}'`); |
There was a problem hiding this comment.
Could you add a test for this please.
craigtaub
reviewed
Nov 23, 2019
| @@ -79,6 +79,7 @@ exports.list = str => | |||
| * @param {string[]} requires - Modules to require | |||
| * @private | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Doesnt need the space (same below)
|
🤖 Closing out old PRs to keep the queue small. Please yell at me if you'd like to keep working on this. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In handleRequires, a function that handles exceptions when invoking a module that does not exist with the
--requireoption. However, function handleRequires can also be used to load non-existent files with the--fileoption.So I added this function to be called when I loaded the file using --file option. And I modified the annotation of this function.
Benefits
When user import a non-existent file or module, command line can show the user the same error message and format.