Refactor allocator to attempt to reduce complexity #2823
+28
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dperny @andrey-ko PTAL |
Codecov Report
@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
+ Coverage 61.62% 61.67% +0.05%
==========================================
Files 139 139
Lines 22615 22612 -3
==========================================
+ Hits 13936 13947 +11
+ Misses 7194 7185 -9
+ Partials 1485 1480 -5 |
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
bcdfe65
to
e3f7b31
Compare
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
e3f7b31
to
8c48ead
Compare
|
rebased to kick CI again |
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
8c48ead
to
971b9d5
Compare
|
rebased again |
|
ping @dani-docker @dperny ptal |
|
All 3 LGTM 👍 |
|
@dperny ptal |
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
971b9d5
to
68c710d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
+ Coverage 61.75% 61.79% +0.04%
==========================================
Files 155 155
Lines 31145 31138 -7
==========================================
+ Hits 19234 19243 +9
+ Misses 10361 10349 -12
+ Partials 1550 1546 -4 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
68c710d
to
8a13d59
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
reduce_allocator_complexity
branch
from
8a13d59
to
b0ee1de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is built on top of #2821see individual commits for a description of the changes 🤗