Always set (empty) UpdateStatus #2820
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dperny @aaronlehmann PTAL; I haven't fully triaged if this could have side-effects, but noticed I still had this change in my local repo after looking at moby/moby#28012 (comment), so thought I'd push it as a PR 🤗 😇 |
Codecov Report
@@ Coverage Diff @@
## master #2820 +/- ##
==========================================
- Coverage 62.01% 61.98% -0.04%
==========================================
Files 139 137 -2
Lines 22123 22145 +22
==========================================
+ Hits 13720 13727 +7
- Misses 6930 6939 +9
- Partials 1473 1479 +6 |
When deploying a service the `UpdateStatus.State` field is not present during `docker service create`. This complicates creating scripts that check for `UpdateStatus.State` to reach a certain state, as they have to take into account that the `UpdateStatus` as a whole is missing. This patch always sets the `UpdateStatus.State` to make it easier to consume. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
always_set_updatestatus
branch
from
4ecb32b
to
96f1b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a service the
UpdateStatus.Statefield is not presentduring
docker service create. This complicates creating scripts thatcheck for
UpdateStatus.Stateto reach a certain state, as they have to takeinto account that the
UpdateStatusas a whole is missing.This patch always sets the
UpdateStatus.Stateto make it easier to consume.addresses moby/moby#28012