New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting a new set methods #3853
Draft
inoyakaigor
wants to merge
10
commits into
mobxjs:main
Choose a base branch
from
inoyakaigor:3850-new-set-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6572115
3850 - if you're using the corepack (https://nodejs.org/api/corepack.…
inoyakaigor eabcdde
3850 - first implementation of new Set methods
inoyakaigor 9763039
3850 - call a method on the argument
inoyakaigor 7131add
3850 - Add code to few another Set methods; align typings to TS PR#57230
inoyakaigor 6b93c8a
3850 - review fixes: move reportObserved() into conditions branch; ch…
inoyakaigor 4e438bb
3850 - add rest of the Set methods
inoyakaigor f5d6863
3850 - align functions parameter type declarations with its expected …
inoyakaigor 46df92b
3850 - update TS to version with new Set methods; remove copied types…
inoyakaigor 4a258c7
3850 - fix type for the «difference» function
inoyakaigor cf22937
3850 - add ESNext to tsconfig lib to fix tests
inoyakaigor File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO remove before merge