Add support for WeakRefs #3637
Open
Add support for WeakRefs #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c20a32c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Matchlighter
force-pushed
the
weakref
branch
3 times, most recently
from
1bf10cd
to
59d94d4
Compare
Matchlighter
force-pushed
the
weakref
branch
from
59d94d4
to
c20a32c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement options for making
computeds andreactions/autorunsgarbage-collectable without manually disposing them.I've had a couple apps that I've needed to use
keepAlivecomputeds. I'm lazy and can't make promises that future me/future my app will dispose them properly. Now that JS supportsWeakRefs, this is a less of a problem. The use case is pretty slim, mainly aroundcomputed(() => {}, { keepAlive: true })stuff, but it can be used forautorunstoo (though you'll need to keep a reference to theautorunin some other way less it fall out of scope and get garbage collected)./docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)