add function to check for constant model while focussearch #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want that in the master branch for 0.1, since we mainly use it for checking I think we can leave it as an branch. |
jakobbossek
reviewed
Nov 24, 2016
R/getExtras.R
Outdated
| } else { | ||
| ex$constant.model = FALSE | ||
| } | ||
| # if we use asyn MBO store node information and evaluation starte |
There was a problem hiding this comment.
Why that complicated?
ex$constant.model = isTRUE(attr(prop$prop.points, "constant.model"))# Conflicts: # R/getExtras.R
# Conflicts: # R/doc_mbo_OptPath.R # R/infillOptCMAES.R # man/mbo_OptPath.Rd # man/setMBOControlMultiPoint.Rd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with #258
adds another column to the opt path where it saves whether the predictions were constant.
also finishes focussearch earlier.