Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use predict generic for mini-batch kmeans #71

Merged
merged 7 commits into from
May 18, 2024
Merged

refactor: use predict generic for mini-batch kmeans #71

merged 7 commits into from
May 18, 2024

Conversation

m-muecke
Copy link
Member

@m-muecke m-muecke commented May 9, 2024 •
edited

Closes: #47

Changes:

  • Use predict generic for ClusterR package (fixed deprecation warning)
  • Bump pre-commit and add missing deps
  • Update lintr config
  • Remove unneeded return statements (mlr3 style)
  • mlr3 style task docs and templates

@damirpolat damirpolat merged commit a8acb82 into mlr-org:main May 18, 2024
4 checks passed
@damirpolat
Copy link
Member

Great, thank you! Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: predict_MBatchKMeans() was deprecated in ClusterR 1.3.0.
2 participants
@m-muecke @damirpolat