feat(marshaling): also marshal during predict #1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
unmarshal = FALSE
not ensures that all models are in unmarshaled form (resample()
,benchmark()
). This is just easier to reason aboutLearner$predict()
, but the model will be restored to its state before prediction.LearnerClassifDebug
now got an argument calledcheck_pid
that isFALSE
by default. If this is set toTRUE
, theunmarshal_model()
method formodel_classif_debug
sets themarshal_pid
slot of the model. The private$.predict()
method ofLearnerClassifDebug
then checks that themarhsal_pid
is equal toSys.getpid()
. This lets us test that the unmarshaling is executed correctly for the prediction.