Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic minimap functionality #19

Draft
wants to merge 1 commit into
base: 3ds-port
Choose a base branch
from
Draft

Basic minimap functionality #19

wants to merge 1 commit into from

Conversation

mkst
Copy link
Owner

@mkst mkst commented Aug 26, 2020

Creating PR to track progress.

Known issues:

  • Texture corruption after playing for a while; I guess I'm not doing texture loading quite right...

Resolved issues:

  • Goddard doesnt reset map when playing demos
  • Star select screen minimap does not match reality.
  • Trying to leave 'console' touch-screen (disable AA/800px etc) breaks bottom screen; I haven't worked out how to de-initialise the console, I hoped just setting the gfxSetScreenFormat back to GSP_RGBA8_OES would do the trick.
  • The Mario texture is a symlink to the (extracted) textures/segment2/segment2.05A00.rgba16.png; symlinks are iffy at best on Windows. If you have issues, copy the files manually
cp textures/segment2/segment2.081D0.rgba16.png src/minimap/textures/arrow.png
cp textures/segment2/segment2.05A00.rgba16.png src/minimap/textures/mario.png

@mkst mkst force-pushed the 3ds-minimap branch 22 times, most recently from 2880761 to 91a56d8 Compare September 2, 2020 20:26
@mkst mkst force-pushed the 3ds-minimap branch 8 times, most recently from 87a316b to c248e3c Compare September 8, 2020 14:26
@mkst mkst force-pushed the 3ds-minimap branch 11 times, most recently from d88ab1a to 7a2e471 Compare September 17, 2020 21:31
@ryotoko
Copy link

ryotoko commented Sep 20, 2020

Minimaps should be disabled during the credits. Think this caused a crash for me, though it's hard to tell

@mkst
Copy link
Owner Author

mkst commented Sep 21, 2020

2020-09-20_18-05-35 613_top
The ending cutscene text is also an issue. It was previously white and appeared on the black letterbox, a nobrainer. But it now appears over the scene. In my last commit, I changed it to black, which isn't much better. Could we put it into the bottom screen, maybe? The minimap would be disabled at this point.

were credits rendered correctly with the viewport being set right? Wondering if it's a side-effect of some other change I've made, unrelated to this?

@ryotoko
Copy link

ryotoko commented Sep 21, 2020

2020-09-21_11-36-15 061_top
A bug with the minimap branch only, Peach letter fade transition only affects her hair now. I think this is due to how area.c's render_game was changed. This function is also going to be key to eliminating the minimaps from the ending scene. I have a good idea of how to fix it

@BopItFreak
Copy link

Any updates on this @mkst ?

@mkst
Copy link
Owner Author

mkst commented Mar 11, 2021

Any updates on this @mkst ?

No updates from me. Am leaving this to be crowd-sourced. I'm working on other things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants