Improve build #114
Open
Improve build #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asarhaddon
force-pushed
the
improve-build
branch
from
b66c1e4
to
a7984cb
Compare
|
Hello. |
asarhaddon
force-pushed
the
improve-build
branch
from
a7984cb
to
ffeb2dc
Compare
Gprbuild knows better than Make about Ada dependencies. Repeating them manually for Make is error-prone. As a compromise: * Make runs gprbuild when at least an Ada source changed. * when it does, it considers that the data must be refreshed because the generator may produce different results. Before this commit, changing a generator was not triggering a rebuild of all dictionaries.
A file on disk was probably required in the 90s, but nowadays the whole file can be stored in RAM, which is way faster. Instead of explicitly sorting, build an ordered set during input. Anything O(n log n) should do.
asarhaddon
force-pushed
the
improve-build
branch
from
ffeb2dc
to
eaf9881
Compare
|
I have removed some cosmetic changes in order to ease review. The monolithic library stuff is unrelated, but affects the same projects, so I want to avoid merge work if possible. The discussion in #112 raised no objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various but interconnected suggestions.
The first commit is a prerequisite for test-english-to-latin.