Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curses support to ttyplay #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NHTangles
Copy link

for improved rendering of ttyrecs of NetHack games using the
curses interface.

for improved rendering of ttyrecs of NetHack games using the
curses interface.
@mjording
Copy link
Owner

Curses has a much larger footprint then termios, so at least I appreciate the request as a feature flag. I'd be interested to see a bit of benchmarking. Have you had a chance to exercise the branch in the wild?

@mjording mjording self-requested a review May 31, 2017 05:30
Copy link
Owner

@mjording mjording left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curses has a much larger footprint then termios, so at least I appreciate the request as a feature flag. I'd be interested to see a bit of benchmarking. Have you had a chance to exercise the branch in the wild?

@mjording mjording self-assigned this May 31, 2017
@NHTangles
Copy link
Author

Thanks for the review! No I have not done any benchmmarking, but as a bit of background, this is something that is needed to accurately replay ttyrecs of games which use curses for rendering such as this https://nethackwiki.com/wiki/Curses_interface, that are recoreded via dgamelaunch (https://github.com/altorg/dgamelaunch). Some examples (try playing them with and without the changes and you will see the difference):
https://www.hardfought.org/userdata/T/Tangles/un531/ttyrec/2017-05-31.09:14:57.ttyrec
https://s3.amazonaws.com/altorg/ttyrec/Tangles/2015-12-05.09:26:30.ttyrec.bz2

Cheers!

@NHTangles
Copy link
Author

The inclusion by the NetHack devteam of the curses windowport in the official NetHack source tree (NetHack 3.6.2beta01 - not yet released) seems like a good reason to bump this. This beta is already getting a lot of play on the hardfought.org public server, and when it goes to release, demand for curses support in ttyplay is only going to increase. Is there anything I can help you out with to make these changes easier for you to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants