Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js rewrite #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Js rewrite #2

wants to merge 3 commits into from

Conversation

moudy
Copy link

@moudy moudy commented Mar 29, 2011

I restructured the application.js file so that everything is name-spaced into a global 'Kajoo' object. I also fixed an instance of where a call to the method 'lon()' should be 'lgn()'. In a few of the view files I had to prepend 'Kajoo.Location' to call methods that were previously global.

I didn't introduce any new bugs (from what I can tell) so it should work the same as it did before. The javascript code could use further refactoring but it's a start and provides a structure to work with.

This is my first attempt to contribute to a project. Hope it makes sense and helps.

Moudy

@gravityrail
Copy link

You rock!

On 29 March 2011 15:43, moudy <
reply@reply.github.com>wrote:

I restructured the application.js file so that everything is name-spaced
into a global 'Kajoo' object. I also fixed an instance of where a call to
the method 'lon()' should be 'lgn()'. In a few of the view files I had to
prepend 'Kajoo.Location' to call methods that were previously global.

I didn't introduce any new bugs (from what I can tell) so it should work
the same as it did before. The javascript code could use further refactoring
but it's a start and provides a structure to work with.

This is my first attempt to contribute to a project. Hope it makes sense
and helps.

Moudy

Reply to this email directly or view it on GitHub:
#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants